Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indent rule is warning wrong on callbacks (master branch) #4142

Closed
mysticatea opened this issue Oct 15, 2015 · 0 comments
Closed

indent rule is warning wrong on callbacks (master branch) #4142

mysticatea opened this issue Oct 15, 2015 · 0 comments
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@mysticatea
Copy link
Member

I'm using ESLint of code-path-analysis/new branch in my job. (to test the analysis).
Then I found indent rule's wrong warnings.
This is not reproduced in v1.6.0, but reproduced in master branch.

/* eslint-env es6 */
/* eslint indent:[2,4] */
let foo = somethingList
    .filter(x => {
        return x;
    })
    .map(x => {
        return 100 * x;
    });
> git log -1
commit c1cd2b88c954e1ce24960126a50367885029f1db
...
> node .\bin\eslint.js test.js --no-ignore --no-eslintrc

C:\Users\t-nagashima.AD\Documents\GitHub\eslint\test.js
  5:9  error  Expected indentation of 4 space characters but found 8  indent
  6:5  error  Expected indentation of 0 space characters but found 4  indent
  8:9  error  Expected indentation of 4 space characters but found 8  indent
  9:5  error  Expected indentation of 0 space characters but found 4  indent

✖ 4 problems (4 errors, 0 warnings)

I expected no errors.

@mysticatea mysticatea added bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Oct 15, 2015
@gyandeeps gyandeeps added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 15, 2015
@gyandeeps gyandeeps self-assigned this Oct 15, 2015
nzakas added a commit that referenced this issue Oct 16, 2015
Fix: `indent` arrow function check fix (fixes #4142)
lizardruss pushed a commit to codeschool/eslint that referenced this issue Oct 29, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

2 participants