Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master failing on Windows #4285

Closed
gyandeeps opened this issue Oct 29, 2015 · 4 comments
Closed

master failing on Windows #4285

gyandeeps opened this issue Oct 29, 2015 · 4 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features infrastructure Relates to the tools used in the ESLint development process

Comments

@gyandeeps
Copy link
Member

Current master is failing because of 2 cache functionality tests.
I suspect the changes made in #4255 might have something to do with as it was working before.

Output:

  7047 passing (1m)
  2 failing

  1) CLIEngine executeOnFiles() cache should create the cache file inside the provided directory using the cacheLocation option:
     AssertionError: the cache for eslint was created: expected false to be true


  2) CLIEngine executeOnFiles() cache when the cacheFile is a directory or looks like a directory should create the cache file inside the provided dir
ectory:
     AssertionError: the cache for eslint was created: expected false to be true

OS affected: Windows 10 & 8

@royriojas anything you might know?

@gyandeeps gyandeeps added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process labels Oct 29, 2015
@royriojas
Copy link
Contributor

@gyandeeps

Will try on a windows machine, not really sure what might be happening

Let me see.

@gyandeeps
Copy link
Member Author

@royriojas Thanks for checking.

@royriojas
Copy link
Contributor

I added the fix for windows. It should work now fine for windows paths.

ilyavolodin added a commit that referenced this issue Oct 29, 2015
Fix: `cacheLocation` handles paths in windows style. (fixes #4285)
@ilyavolodin
Copy link
Member

Verified that the tests are no longer failing. Thanks @royriojas

lizardruss pushed a commit to codeschool/eslint that referenced this issue Oct 29, 2015
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

No branches or pull requests

3 participants