Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-nested-callbacks has no default #4297

Closed
IanVS opened this issue Oct 30, 2015 · 3 comments
Closed

max-nested-callbacks has no default #4297

IanVS opened this issue Oct 30, 2015 · 3 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@IanVS
Copy link
Member

IanVS commented Oct 30, 2015

We have said in the past that all rules should have sensible defaults. Currently, setting "max-nested-callbacks": 2 does nothing at all. I'm not sure what the right default number would be, but probably something relatively high. Maybe 5?
@IanVS IanVS added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 30, 2015
@michaelficarra
Copy link
Member

The default is Infinity then, no?

@IanVS
Copy link
Member Author

IanVS commented Oct 30, 2015

Yes, I suppose you could think of it that way. I'm not sure I would consider that "sensible", though.

@nzakas
Copy link
Member

nzakas commented Nov 2, 2015

I'd go with 10. Double digits are scary to start without being too restrictive (and unlikely to create debates about the number being too low).

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 2, 2015
@alberto alberto closed this as completed in 99ad1ca Nov 3, 2015
nzakas added a commit that referenced this issue Nov 3, 2015
@nzakas
Merge pull request #4330 from eslint/issue4297
37efece 
Update: Add default to `max-nested-callbacks` (fixes #4297)
@IanVS IanVS mentioned this issue Dec 26, 2015
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @michaelficarra @IanVS