Add Chore to allowed commit tags

[alberto]

As proposed in the chatroom, we could add a tag for internal tasks that don't have observable effect on user experience, such as refactoring, adding tests, removing unused code or general cleanup.

Here are a couple of PRs that would qualify for this.

@eslint/eslint-team opinions?

[kaicataldo]

I'm for the addition of this label. Would be nice to have an easy way to identify tech debt-ish issues.

[platinumazure]

Would we also add a corresponding issue label (perhaps also "chore", to keep it simple)?

[ilyavolodin]

We need to update Maintainer guide, bot and build script if we are adding a new label.

[mikesherov]

👍 @ilyavolodin @alberto, I'd like to work on this, as it'd be a nice first issue for me, where I can get familiar with some of the team's tooling.

Is that ok?

[ilyavolodin]

@mikesherov Sounds good. Just need to wait a little bit for @nzakas to mark this as approved, but since he is the one who proposed it, I don't see a problem with it. Also, bot is currently not open sourced, so @nzakas will have to make that change. Everything else is up for grabs

[ilyavolodin]

Oh and forgot about release script. I think there might need to be some modifications there to aggregate base log entries based on the new label (although I don't remember if the list of labels is supplied there or it's just aggregating everything that it finds, without caring what it is).

[alberto]

@mikesherov 👍 welcome to the team!

I looked at eslint-release and it doesn't look like any changes are needed.

Someone else with permissions will have to create the label, too.

[mikesherov]

@nzakas any chance I can get access to the repo for the eslint bot?

[nzakas]

The things that need to be updated are:

1. Bot message - https://github.com/eslint/eslint/blob/master/templates/pr-create.md.ejs
2. Bot message test - https://github.com/eslint/eslint/blob/master/tests/templates/pr-create.md.ejs.js
3. Documentation - https://github.com/eslint/eslint.github.io/blob/master/docs/developer-guide/contributing/pull-requests.md and https://github.com/eslint/eslint.github.io/blob/master/docs/developer-guide/contributing/working-on-issues.md
4. Blog post template - https://github.com/eslint/eslint/blob/master/templates/blogpost.md.ejs
5. Makefile.js - https://github.com/eslint/eslint/blob/master/Makefile.js#L71

[nzakas]

I created the label. Not sure why you couldn't @alberto, I need to double check the permissions setup.

[platinumazure]

@nzakas Also we need to update Makefile.js so that npm run check-commit will accept the new label, or has that been done already?

[nzakas]

@platinumazure oops, forgot about that. Added.

[alberto]

@mikesherov are you working on this?

[mikesherov]

Yup. I'll do it tonight. Thanks for the ping

[alberto]

Cool. I just asked because we are already using the new tag, so it would be nice to have this soon.

[mikesherov]

PR coming soon

[mikesherov]

#5929 @alberto @nzakas review?

[mikesherov]

@nzakas looks like you already took care of the Documentation.