Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camelcase shouldn't warn when reading properties #672

Closed
nzakas opened this issue Mar 12, 2014 · 2 comments · Fixed by #674
Closed

camelcase shouldn't warn when reading properties #672

nzakas opened this issue Mar 12, 2014 · 2 comments · Fixed by #674
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@nzakas
Copy link
Member

nzakas commented Mar 12, 2014

Similar to #656, if you're reading a property value that has underscores in it, it shouldn't be your fault. A lot of web services do this, as well as libraries. So this should be okay:

var foo = bar.baz_boom;

This should still warn:

bar.baz_boom = "foo";
@makepanic
Copy link
Contributor

Did you mean that no-underscore-dangle should be okay with:

var foo = bar._baz;

And warn when using:

bar.boom_ = "foo";

The snippets you described look like camelcase examples.

@nzakas
Copy link
Member Author

nzakas commented Mar 12, 2014

Oops, this should be about the camelcase rule. Thanks for pointing it out.

iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 12, 2014
@iancmyers
Relaxed enforcement of camelcase rule
6461cef 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
@iancmyers iancmyers mentioned this issue Mar 12, 2014
Merged
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 12, 2014
@iancmyers
Relaxed enforcement of camelcase rule
87f4f43 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 12, 2014
@iancmyers
Relaxed enforcement of camelcase rule
27645db 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 12, 2014
@iancmyers
Relaxed enforcement of camelcase rule
f50b7c6 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 13, 2014
@iancmyers
Relaxed enforcement of camelcase rule
cc51472 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 13, 2014
@iancmyers
Relaxed enforcement of camelcase rule
220792f 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
iancmyers added a commit to iancmyers/eslint that referenced this issue Mar 14, 2014
@iancmyers
Relaxed enforcement of camelcase rule
06280f6 
The `camelcase` rule now allows reading underscored properties:

    var foo = bar.baz_boom;

Fixes eslint#672
@joemaller joemaller mentioned this issue Mar 2, 2015
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relaxed enforcement of camelcase rule iancmyers/eslint
2 participants
@nzakas @makepanic