pass config with flag/args #692

tj · 2014-03-20T18:51:38Z

personally I don't want to put comments in a file, or have a global config, Ideally we would just be able to do:

test: lint

lint:
  eslint *.js

.PHONY: test

and specify --node or whatever directly with the executable. Looks like a bunch of non-error defaults are enabled as well :s those should definitely be removed IMO

The text was updated successfully, but these errors were encountered:

nzakas · 2014-03-20T19:02:10Z

Just to clarify: you're asking to be able to configure rules and environments by passing flags on the command line, correct?

If so, do you have a format in mind? We currently have 110 rules, so we probably don't want to create an individual flag for every rule.

Regarding defaults: I don't see removing those. We've tried to keep them to things that are either most problematic or most common, because there are far too many rules to force every developer to go through and manually specify everything up front. I wouldn't be opposed to having a flag that resets everything to being off, though, for those who want it.

tj · 2014-03-20T19:08:39Z

Yup, even if it was still json that would be ok with me, but some sugar like --env node --env browser --globals foo,bar,baz --rule quotes "[2, 'double']" would be nice.

Things like curlies / quotes really don't make good defaults, they're not errors, but a reset would instantly make it better than the other tools

nzakas · 2014-03-20T19:16:36Z

Cool, I think the task list for this is (in increasing order of complexity):

Create a flag that resets every rule to be off
Create a flag that enables environments
Create a flag that specifies globals
Create a flag that specifies rule configuration

tj · 2014-03-20T19:18:54Z

Sweet thanks for considering the changes, I'll try and help today if I get some time

nzakas · 2014-03-20T21:36:48Z

FWIW, I think the flag for wiping the slate clean can just avoid loading conf/eslint.json.

tj · 2014-03-20T21:45:14Z

It would be nice to still enable some, just errors though, maybe eslint core can provide a few boilerplate configurations?

nzakas · 2014-03-20T23:33:33Z

Oh yeah, what I mean is that we load conf/eslint.json first and then
merge any changes into that. If just don't load that file, and instead
merge into an empty config, you essentially get to start from scratch and
just add what you want.

Also, you've said "errors" a couple times, but I'm not clear on what those
are. Are you talking syntax errors only?

tj · 2014-03-21T00:17:14Z

Yeah pretty much just syntax errors and dead code, most of the "Possible Error" rules are reasonable as defaults, the rest definitely not

jonathanKingston · 2014-03-21T01:10:45Z

Is it worth having a command line flag/s to turn sections of the rules off to simplify specification?

So the sections would be those set out in the rules page

eslint --node --possible-errors --stylistic-errors off

tj · 2014-03-21T01:27:58Z

that would be cool too, but the granularity we were talking about earlier would definitely be helpful as well

nzakas · 2014-03-21T16:12:29Z

The categorization is for documentation purposes only right now, there was very little though put into them and they're still changing as rules get added, changed, and removed. I wouldn't want to formalize the grouping into code at this point.

jonathanKingston · 2014-03-21T18:16:02Z

@nzakas I was feeling you were going to say that, was worth the suggestion anyway.

nzakas · 2014-03-21T23:40:47Z

Totally, never hold back with suggestions. :)

Adds a --reset (-r) flag to the cli options that resets all default rules to be off.

Adds a --reset flag to the cli options that resets all default rules to be off.

Add --env cli flag (ref #692)

Adds a --globals cli flag to define global variables. Takes a comma- separated list of variable names to define. By default, all varibles are read-only, but appending `:true` to the name will mark it as writable. Example: eslint --globals require,exports:true file.js

Adds a --globals cli flag to define global variables. Takes a comma- separated list of variable names to define. By default, all variables are read-only, but appending `:true` to the name will mark it as writable. Example: eslint --globals require,exports:true file.js

Adds a --global cli flag to define global variables. To define multiple variables, either separate them using commas, or use the flag multiple times. By default, all variables are read-only, but appending `:true` to the name will mark it as writable. Example: eslint --global require,exports:true file.js eslint --global require --global exports:true file.js

Adds a --globals cli flag to define global variables. To define multiple variables, either separate them using commas, or use the flag multiple times. By default, all variables are read-only, but appending `:true` to the name will mark it as writable. Example: eslint --globals require,exports:true file.js eslint --globals require --globals exports:true file.js

Add global cli flag (ref #692)

nzakas · 2014-04-09T17:20:49Z

3/4 of the way there thanks to @btmills and @gkz

gkz · 2014-04-11T20:54:44Z

With Optionator, it is possible to add a flag called rules with the type Object, then:

--rules 'brace-style: [2, 1tbs], radix: 2'

results in:

{
  rules: {
    'brace-style': [ 2, '1tbs' ],
    radix: 2
  }
}

pretty easy!

btmills · 2014-04-11T20:57:50Z

Sweet! By extension, will [Object] work with a singular --rule flag to match --env and --global?

gkz · 2014-04-11T21:01:12Z

Actually I was just thinking about that.
The option that I added merges arrays, but what is required here is to merge objects ([Object] means an array of Objects). You don't want an array of objects specifying rules, you want a single object specifying all the rules.
I can add this functionality to the next version of Optionator.

if you repeat a flag, which contains an object value, (eg. of type [Object]), it will merge the objects rather than overwrite the whole thing stemming from eslint/eslint#692

gkz · 2014-05-09T03:47:54Z

As of optionator 0.4.0, published a week ago, you can use the mergeRepeatedObjects option and that will allow you to add the rule flag as I mentioned a while ago. I just don't know exactly what logic you want with that flag - where/how the rules specified on the command line should be merged.

nzakas · 2014-05-13T15:20:11Z

We basically need to treat these the same as do the -c option (which reads config from a file)

add rule flag, closes #692

nzakas · 2014-05-17T19:27:24Z

@visionmedia all of these are in 0.6.1 now. The --rule flag was just added: http://eslint.org/docs/command-line-interface/

nzakas added the enhancement label Mar 20, 2014

btmills mentioned this issue Mar 26, 2014

Add reset cli flag #714

Merged

btmills added a commit to btmills/eslint that referenced this issue Mar 26, 2014

Add reset cli flag (refs eslint#692)

340b71c

Adds a --reset (-r) flag to the cli options that resets all default rules to be off.

btmills added a commit to btmills/eslint that referenced this issue Mar 26, 2014

Add reset cli flag (refs eslint#692)

f17307a

Adds a --reset (-r) flag to the cli options that resets all default rules to be off.

btmills added a commit to btmills/eslint that referenced this issue Mar 26, 2014

Add reset cli flag (refs eslint#692)

d90413f

Adds a --reset flag to the cli options that resets all default rules to be off.

btmills added a commit to btmills/eslint that referenced this issue Mar 31, 2014

Add --env cli flag (ref eslint#692)

b1c88d2

btmills added a commit to btmills/eslint that referenced this issue Mar 31, 2014

Add --env cli flag (ref eslint#692)

4ab802b

nzakas added a commit that referenced this issue Mar 31, 2014

Merge pull request #745 from btmills/env-flag

f6282db

Add --env cli flag (ref #692)

This was referenced Apr 7, 2014

Reevaluate CLI parser #769

Closed

Replace optionator with nopt (fixes #769) #770

Closed

nzakas added a commit that referenced this issue Apr 9, 2014

Merge pull request #751 from btmills/globals-flag

f49781d

Add global cli flag (ref #692)

gkz added a commit to gkz/optionator that referenced this issue Apr 23, 2014

add merge-repeated-objects option

1b1224b

if you repeat a flag, which contains an object value, (eg. of type [Object]), it will merge the objects rather than overwrite the whole thing stemming from eslint/eslint#692

nzakas mentioned this issue May 16, 2014

add rule flag, closes #692 #872

Merged

nzakas added this to the v0.6.0 milestone May 16, 2014

nzakas closed this as completed in d4d364e May 17, 2014

nzakas added a commit that referenced this issue May 17, 2014

Merge pull request #872 from gkz/rule-flag

43ce28f

add rule flag, closes #692

btmills mentioned this issue May 27, 2014

Define priority order for configurations #939

Closed

eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pass config with flag/args #692

pass config with flag/args #692

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 21, 2014

jonathanKingston commented Mar 21, 2014

tj commented Mar 21, 2014

nzakas commented Mar 21, 2014

jonathanKingston commented Mar 21, 2014

nzakas commented Mar 21, 2014

nzakas commented Apr 9, 2014

gkz commented Apr 11, 2014

btmills commented Apr 11, 2014

gkz commented Apr 11, 2014

gkz commented May 9, 2014

nzakas commented May 13, 2014

nzakas commented May 17, 2014

pass config with flag/args #692

pass config with flag/args #692

Comments

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 20, 2014

nzakas commented Mar 20, 2014

tj commented Mar 21, 2014

jonathanKingston commented Mar 21, 2014

tj commented Mar 21, 2014

nzakas commented Mar 21, 2014

jonathanKingston commented Mar 21, 2014

nzakas commented Mar 21, 2014

nzakas commented Apr 9, 2014

gkz commented Apr 11, 2014

btmills commented Apr 11, 2014

gkz commented Apr 11, 2014

gkz commented May 9, 2014

nzakas commented May 13, 2014

nzakas commented May 17, 2014