-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct eol-last desire value documentation #7227
Conversation
@chaintan17, thanks for your PR! By analyzing the annotation information on this pull request, we identified @scriptdaemon, @pedrottimark and @Kdex to be potential reviewers |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC "always"
is the default anyway, so the behavior should be equivalent to the previous version. But I do agree that being explicit about the parameters is a lot better in terms of documentation. Thank you! LGTM 👍
setting just I think we need to make backward compatability also because it's minor release. What do you think @Kdex ? |
@chaintng Hm, I've failed to reproduce this on ESLint 3.5.0 and 3.6.0 with the following file: /* eslint eol-last: ["error"] */\n
var a = 2; The output is as expected:
If you have a consistent way of reproducing this error, could you please— in addition to this PR—open up an issue about it? |
0d9ebc9
to
1e44822
Compare
LGTM |
Ah, yes. i was misunderstanding. i try |
Travis indeed failed for some node versions. The build and tests for Node 4.x were successful. Node 5.x and 6.x failed with:
which seems like a problem on our end; don't worry about it. It has nothing to do with For more information on the failure, see #7239. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @chaintng!
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Correct desire eol-last value after this pull request #6952
Is there anything you'd like reviewers to focus on?
nope :)