Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list for 4.0.0 #7407

Closed
not-an-aardvark opened this issue Oct 19, 2016 · 7 comments
Closed

To-do list for 4.0.0 #7407

not-an-aardvark opened this issue Oct 19, 2016 · 7 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion needs bikeshedding Minor details about this change need to be discussed
Milestone

Comments

@not-an-aardvark
Copy link
Member

There are a lot of issues where we have discussed changing behavior in the next major version, but we haven't really kept track of these. This issue is intended to be a place to put breaking changes that we are evaluating, so that we don't forget make those changes when the release happens.


Accepted changes:

@not-an-aardvark not-an-aardvark added core Relates to ESLint's core APIs and features needs bikeshedding Minor details about this change need to be discussed breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 19, 2016
@not-an-aardvark not-an-aardvark added this to the v4.0.0 milestone Oct 19, 2016
@not-an-aardvark
Copy link
Member Author

not-an-aardvark commented Oct 19, 2016

Here are a few changes I think we should make:

  • Rules to add to eslint:recommended:
  • Changes to rule defaults:
    • For indent, set {MemberExpression: 1} by default. (already done in rewrite)
    • For valid-typeof, set {requireStringLiterals: true} by default.
    • For no-extra-parens, set {nestedBinaryExpressions: false} by default (to avoid conflicting with no-mixed-operators)
    • For space-before-function-paren, set {asyncArrow: "always"} by default (it is currently "ignore" for backwards-compatibility, but it's inconsistent with the other options).
  • Other:
    • Hopefully get the indent rewrite in (meta-issue: indent rule discussion #7274). The indent rewrite currently checks a lot of indentation cases that the current rule ignores. I think this is a good thing (ideally, no cases would be ignored by default), but it's possible it will cause a lot of builds to fail. We should make sure to put it in 4.0.0 if it's not already in by then.

@kaicataldo
Copy link
Member

I'm hoping that the comment attachment changes also get in

@not-an-aardvark
Copy link
Member Author

not-an-aardvark commented Dec 4, 2016

As discussed in #7689, we should consider reporting an error for for ObjectExpression and ArrayExpression errors/rejection reasons in no-throw-literal and no-reject-literal.

@platinumazure
Copy link
Member

Possible addition: Refactor public-facing APIs to use ES6 classes, where feasible (this can't be done outside of semver-major, for sure).

@JamesHenry
Copy link
Member

@nzakas Will we able to get eslint/eslint-scope into v4 do you think?

@nzakas
Copy link
Member

nzakas commented Feb 9, 2017

Yeah, we should work to get eslint-scope into 4.0.0. We should probably open an issue on babel-eslint to let them know of the change ahead of time.

@not-an-aardvark
Copy link
Member Author

I'm going to close this issue in favor of using the v4.0.0 project for tracking instead. The changes that have been suggested are all already on the tracking project in some form.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion needs bikeshedding Minor details about this change need to be discussed
Projects
None yet
Development

No branches or pull requests

5 participants