Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list for 4.0.0 #7407

Closed
not-an-aardvark opened this issue Oct 19, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@not-an-aardvark
Copy link
Member

commented Oct 19, 2016

There are a lot of issues where we have discussed changing behavior in the next major version, but we haven't really kept track of these. This issue is intended to be a place to put breaking changes that we are evaluating, so that we don't forget make those changes when the release happens.


Accepted changes:

  • Core:
    • Fix scoped plugin names (#6362)
    • Calculate leading/trailing comments (#6724)
    • Fix ignore-path relative paths (#6759)
    • Traverse into type annotations (#7129)
  • eslint:recommended changes:
    • (none yet)
  • Other rule changes:
    • (none yet)
@not-an-aardvark

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2016

Here are a few changes I think we should make:

  • Rules to add to eslint:recommended:
    • (discussion moved to #8236)
  • Changes to rule defaults:
    • For indent, set {MemberExpression: 1} by default. (already done in rewrite)
    • For valid-typeof, set {requireStringLiterals: true} by default.
    • For no-extra-parens, set {nestedBinaryExpressions: false} by default (to avoid conflicting with no-mixed-operators)
    • For space-before-function-paren, set {asyncArrow: "always"} by default (it is currently "ignore" for backwards-compatibility, but it's inconsistent with the other options).
  • Other:
    • Hopefully get the indent rewrite in (meta-issue: #7274). The indent rewrite currently checks a lot of indentation cases that the current rule ignores. I think this is a good thing (ideally, no cases would be ignored by default), but it's possible it will cause a lot of builds to fail. We should make sure to put it in 4.0.0 if it's not already in by then.
@kaicataldo

This comment has been minimized.

Copy link
Member

commented Oct 19, 2016

I'm hoping that the comment attachment changes also get in

@not-an-aardvark

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2016

As discussed in #7689, we should consider reporting an error for for ObjectExpression and ArrayExpression errors/rejection reasons in no-throw-literal and no-reject-literal.

@platinumazure

This comment has been minimized.

Copy link
Member

commented Jan 4, 2017

Possible addition: Refactor public-facing APIs to use ES6 classes, where feasible (this can't be done outside of semver-major, for sure).

@JamesHenry

This comment has been minimized.

Copy link
Member

commented Feb 7, 2017

@nzakas Will we able to get eslint/eslint-scope into v4 do you think?

@nzakas

This comment has been minimized.

Copy link
Member

commented Feb 9, 2017

Yeah, we should work to get eslint-scope into 4.0.0. We should probably open an issue on babel-eslint to let them know of the change ahead of time.

@ilyavolodin ilyavolodin added this to InProgress in v4.0.0 Feb 23, 2017

@ilyavolodin ilyavolodin moved this from Accepted & InProgress to Needs Discussion in v4.0.0 Mar 16, 2017

@not-an-aardvark

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2017

I'm going to close this issue in favor of using the v4.0.0 project for tracking instead. The changes that have been suggested are all already on the tracking project in some form.

@not-an-aardvark not-an-aardvark removed this from Needs Discussion in v4.0.0 Mar 17, 2017

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.