Docs: Update no-tabs to match existing standards & improve readbility #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stowball, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps to be a potential reviewer. |
|
|
|
LGTM |
gyandeeps
approved these changes
Nov 13, 2016
ilyavolodin
suggested changes
Nov 13, 2016
| @@ -1,10 +1,10 @@ | |||
| # Disallow tabs in file (no-tabs) | |||
There was a problem hiding this comment.
If you are updating this title, this should also be updated in the rule's metadata. Otherwise rule index page is going to have different title.
kaicataldo
added
accepted
|
LGTM |
ilyavolodin
approved these changes
Nov 14, 2016
|
@stowball Thanks. LGTM. It looks like there's a merge conflict with |
stowball
force-pushed
the
no-tabs-docs-improvement
branch
from
75ed2ba
to
450744e
Compare
|
LGTM |
ilyavolodin
approved these changes
Nov 15, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
No logged issue, I just noticed that the new docs for
no-tabweren't as "professional" as the rest.What changes did you make? (Give an overview)
Updated to match existing docs standards and improve the readability of the content.
Is there anything you'd like reviewers to focus on?
No