Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update no-tabs to match existing standards & improve readbility #7590

Merged
merged 2 commits into from Nov 15, 2016
Merged

Docs: Update no-tabs to match existing standards & improve readbility #7590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94a611d
Docs: Update no-tabs to match existing standards & improve readbility
stowball Aug 16, 2016
450744e
Update no-tabs meta data to reflect docs change
stowball Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/rules/no-tabs.md
View file
Open in desktop
@@ -1,10 +1,10 @@
# Disallow tabs in file (no-tabs)
# disallow all tabs (no-tabs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are updating this title, this should also be updated in the rule's metadata. Otherwise rule index page is going to have different title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


some style guides don't allow the use of tab characters anywhere. So they would want to disallow tab anywhere inside a file including comments.
Some style guides don't allow the use of tab characters at all, including within comments.

## Rule Details

This rule looks for tabs inside the file. It can abe anywhere inside code or comments or anything.
This rule looks for tabs anywhere inside a file: code, comments or anything else.

Examples of **incorrect** code for this rule:

Expand Down
2 changes: 1 addition & 1 deletion lib/rules/no-tabs.js
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ const regex = /\t/;
module.exports = {
meta: {
docs: {
description: "disallow tabs in file",
description: "disallow all tabs",
category: "Stylistic Issues",
recommended: false
},
Expand Down