Chore: Refactor to use ES6 Classes (Part 3)(refs #7849) #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyandeeps, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @not-an-aardvark and @nzakas to be potential reviewers. |
|
LGTM |
gyandeeps
added
accepted
platinumazure
approved these changes
Jan 6, 2017
ilyavolodin
approved these changes
Jan 6, 2017
|
I had made #7849 with the intent of leaving these for new contributors, but apologies if that wasn't clear. Been trying to find ways to help get new contributors involved, and refactoring code to use new syntax seems like a pretty great task for that purpose. |
|
@kaicataldo Since i started way before that, i had prepped up a lot of es6 class code already. I just submitted it in different PR's. |
kaicataldo
approved these changes
Jan 6, 2017
|
LGTM, thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x ] Other, please explain:
What changes did you make? (Give an overview)
follow up on previous PR's
Is there anything you'd like reviewers to focus on?