Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update space-before-function-paren docs for 4.0 (fixes #8430) #8431

Merged
merged 1 commit into from
Apr 8, 2017

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Apr 8, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

7dd890d changed the default options for the space-before-function-paren rule, but it did not update the docs to indicate the change. This commit updates the docs.

Fixes #8430

Is there anything you'd like reviewers to focus on?

Nothing in particular

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @BYK and @btmills to be potential reviewers.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation labels Apr 8, 2017
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 446b887 into master Apr 8, 2017
@not-an-aardvark not-an-aardvark deleted the space-before-function-parens-docs-fix branch April 8, 2017 20:44
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants