Upgrade: espree@^3.4.2 #8526
Merged
Upgrade: espree@^3.4.2 #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I had espree@>=3.4.0 <3.4.2 on my system, npm install never updated the package. With ESLint freezing the parser options/config object, seems we are relying on 3.4.2's bugfix not to set ecmaFeatures.impliedStrict. So this dependency really should be at 3.4.2.
|
@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MethodGrab, @nzakas and @alberto to be potential reviewers. |
|
LGTM |
|
Ah, thanks, that's probably why I had to nuke my node_modules and |
vitorbal
approved these changes
Apr 29, 2017
not-an-aardvark
approved these changes
Apr 29, 2017
|
My bad, I should have upgraded this in afbea78. |
kgregory
pushed a commit
to kgregory/eslint
that referenced
this pull request
May 1, 2017
Since I had espree@>=3.4.0 <3.4.2 on my system, npm install never updated the package. With ESLint freezing the parser options/config object, seems we are relying on 3.4.2's bugfix not to set ecmaFeatures.impliedStrict. So this dependency really should be at 3.4.2.
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I had espree@>=3.4.0 <3.4.2 on my system,
npm installnever updated the package. With ESLint freezing the parser options/config object, seems we are relying on 3.4.2's bugfix not to set ecmaFeatures.impliedStrict. So this dependency really should be at 3.4.2.What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Upgrade espree since we are depending on a particular bugfix, see above.
What changes did you make? (Give an overview)
Upgrade espree to 3.4.2. Rationale is above.
Is there anything you'd like reviewers to focus on?
Not really.