-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: fix title of linter test suite #8861
Conversation
The `linter` test suite was still called "eslint" from when lib/linter.js was called lib/eslint.js. This renames the test suite to call it "linter" instead.
LGTM |
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps to be a potential reviewer. |
tests/lib/linter.js
Outdated
@@ -71,7 +71,7 @@ function getVariable(scope, name) { | |||
// Tests | |||
//------------------------------------------------------------------------------ | |||
|
|||
describe("eslint", () => { | |||
describe("linter", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Linter instead? (Are we specifically testing the singleton instance, or the class?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It tests both. Updated to Linter.
LGTM |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
The
linter
test suite was mistakenly still called "eslint" from when lib/linter.js was called lib/eslint.js. This renames the test suite to call it "linter" instead.Is there anything you'd like reviewers to focus on?
No