-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer-arrow-callback: allowUnboundThis description may be confusing #8950
Comments
Thanks for reporting, I agree that the documentation is unclear/misleading here. To answer your questions:
|
Hello friends, Looking to make my first ever PR on this one. Have signed the agreement and will follow the contribution guidelines to the best of my ability. If there is any objection to me taking a crack at this one - please advise. Thanks for the opportunity, Also if anyone has the time, I am open to any suggestions or advice on the direction I should go in fixing this piece of the docs - but it seems pretty straightforward so I am just gonna go for it. I'll state again however, that any and all input is welcome. |
@webdevdaemon Thanks for volunteering! We look forward to your PR 😄 I agree this should be pretty straightforward, so I would suggest giving it a try and then we can provide suggestions as needed while reviewing the pull request. |
SWEET. Thx for the rapid reply - I'm on it. |
I just realized that i PR'd 4 commits rather than just one... I'm sure you'll let me know if I need to fix that... 1000 apologies. PR submitted though! |
http://eslint.org/docs/rules/prefer-arrow-callback#allowunboundthis
I've read this paragraph several times and by comparison with the code example it seems a bit confusing:
"When set to
false
, this option allows the use ofthis
without restriction...": does not the option apply more restrictions for usingthis
?"...checks for dynamically assigned
this
values...": does "checks" mean "prohibits" or "allows"?"Normally, the rule will flag...": does "Normally" mean "true" or "false" for this option?
The code example is clear, but the description seems to be vague.
The text was updated successfully, but these errors were encountered: