-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: upgrade globals
to 11.0.1 (fixes #9614)
#9632
Conversation
@mysticatea I just published v11.0.1. |
@sindresorhus Thank you! |
9915a9e
to
f852fc6
Compare
globals
to 11.0.0 (fixes #9614)globals
to 11.0.0 (fixes #9614)
globals
to 11.0.0 (fixes #9614)globals
to 11.0.1 (fixes #9614)
I think it would be a breaking change. see #9555 |
I'd like to see this land, but I am a little concerned about the breaking changes. This feels like it could affect more users since it's not isolated to a single rule and is an actual change in core. Also, should we close #9555 in favor of this? |
For the environments where globals are being removed: Could we patch those globals in our environment config (as suggested by @not-an-aardvark) and take an action item to remove those patches (and therefore remove the globals for our users) in our next major release? |
I patched the deleted globals of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix (template)
Fixes #9614.
Closes #9555.
What changes did you make? (Give an overview)
This PR upgrades the dependency to
globals
package to11.x
from9.x
(diff).Estimated effects:
no-undef
rule reportsSystem
variables (System
not detected as an undefined variable #9614).no-shadow
andno-redeclare
with{builtinGlobals: true}
option no longer reportSystem
variables.no-extend-native
rule reports aboutAtomics
andSharedBufferArray
.node
environment no longer has the deprecated globals:root
,GLOBAL
, andarguments
.browser
environment is updated massively. The new globals are based on the global variables of current Chrome Canary. EDIT: there are not deleted variablesjasmine
getsspyOnProperty
variable.jest
getswait
variableand no longer hascheck
andgen
.greasemonkey
getsGM
variable.Is there anything you'd like reviewers to focus on?
I think we can release the changes in the next minor version because those are bug fixes.
But the diff is large a bit. What do you think?