New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: remove deprecated browser/jest/node globals (fixes #10141) #10210
Conversation
This removes deprecated globals from the `browser`, `jest`, and `node` environments.
Not that I'm strongly opposed, but I think the issue only really discussed browser/jest globals (although, I do see similar comments in the codebase around the node globals). Do we need to reconfirm with TSC about the node globals? Were the node globals discussed in the meeting? |
You're right -- due to an oversight on my part, I didn't notice that we also had deprecated There wasn't any discussion about node globals at the meeting, although there also wasn't any substantial discussion about the other globals, either -- there was unanimous agreement among those present as soon as the issue was brought up, so we voted on it and moved onto the next issue. The TSC question was "Should we remove the deprecated globals in ESLint 5.0?". Although the summary didn't mention deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though we didn't specifically discuss node
globals, my assumption when I gave my 👍 to the change was that it would apply to all the globals marked as "For backward compatibility. Remove those on the next major release.", so this change matches my expectations.
tl;dr: LGTM
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes deprecated globals from the
browser
,jest
, andnode
environments, as discussed in #10141.Is there anything you'd like reviewers to focus on?
Nothing in particular