Fix: no-invalid-meta crashes for non Object values (fixes #10750) #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
approved these changes
Aug 10, 2018
platinumazure
added
bug
aladdin-add
reviewed
Aug 12, 2018
| { | ||
| code: [ | ||
| "module.exports = {", | ||
| " meta: [],", |
There was a problem hiding this comment.
meta could be an object. is the [] intentional?
There was a problem hiding this comment.
Yes. In case of an emtpy object, node.properties is [] but for any other type it is undefined resulting in a crash. I intentionally declared meta as an array to elicit this case
There was a problem hiding this comment.
I see.thanks for the clarification!
ilyavolodin
approved these changes
Aug 17, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Issue ( #10750 )
What changes did you make? (Give an overview)
getPropertyFromObjecttrying to access thelengthproperty ofundefinedIs there anything you'd like reviewers to focus on?
getPropertyFromObjectfunction across all internal rule files.