Docs: Add jscs-dev.github.io links to rule names in docs #10771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
aladdin-add
added
enhancement
aladdin-add
approved these changes
Aug 17, 2018
|
Closing and reopening to see if the CLA check will repair itself. |
|
@kborchers Any idea what's going on with the license check in this PR? |
ilyavolodin
approved these changes
Aug 18, 2018
|
The CLA bot problem should be solved. I had accidentally broken it in this organization by enabling OAuth app restrictions, but I granted it permission and it seems to be working again. Sorry about the confusion! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I "reverted" a recent pull request that removed links for JSCS rule names spread through the docs. I have replaced them with the new jscs-dev.github.io link target.
Is there anything you'd like reviewers to focus on?
I am probably stepping on this guy's toes ( #10736 ) by doing this but it is a trivial change, and I hope everyone forgives me. If possible though, could I get some guidance on how to deal with the other suggested PRs? #10706 and #10737 as well as any other ones I may have missed? One of them is stuck in triage. I am merely attempting to get some of this stuff moving along through the pipes. Any help with this is appreciated. A way to consolidate all these might be even better!