Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Replace old note about caching with a new one considering autofixes (fixes #10739) #10913

Merged
merged 1 commit into from Oct 8, 2018

Conversation

@zacnomore
Copy link
Contributor

commented Oct 3, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Removed old note and added new note per consideration from @platinumazure

Is there anything you'd like reviewers to focus on?
No.

@eslint eslint bot added the triage label Oct 3, 2018

@zacnomore zacnomore changed the title Replace old note about caching with a new one considering autofixes DOCS: Replace old note about caching with a new one considering autofixes Oct 3, 2018

@zacnomore zacnomore changed the title DOCS: Replace old note about caching with a new one considering autofixes Docs: Replace old note about caching with a new one considering autofixes Oct 3, 2018

@zacnomore zacnomore changed the title Docs: Replace old note about caching with a new one considering autofixes Docs: Replace old note about caching with a new one considering autofixes (fixes #10739) Oct 3, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

Would like another set of eyes on this before merging.

@ilyavolodin ilyavolodin merged commit 557a8bb into eslint:master Oct 8, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 7, 2019

@eslint eslint bot added the archived due to age label Apr 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.