Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add 'When Not To Use' section to space-infix-ops #10931

Merged

Conversation

@madbence
Copy link
Contributor

commented Oct 6, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I added the usual 'When Not To Use It' section to the docs of space-infix-ops.

Is there anything you'd like reviewers to focus on?

I'm not sure if there's anything else that's usually included, but it seems that most of the other rules have this section filled out.

@eslint eslint bot added the triage label Oct 6, 2018

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit f85547a into eslint:master Oct 8, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure

This comment has been minimized.

Copy link
Member

commented Oct 8, 2018

Merged. Thanks @madbence for contributing!

@madbence madbence deleted the madbence:space-infix-ops-when-not-to-use branch Oct 8, 2018

btmills added a commit that referenced this pull request Oct 12, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 7, 2019

@eslint eslint bot added the archived due to age label Apr 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.