Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add instructions for npm 2FA (refs #10631) #10992

Merged
merged 1 commit into from Oct 19, 2018

Conversation

@not-an-aardvark
Copy link
Member

commented Oct 17, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

(refs #10631)

This adds a page to the maintainer guide describing how to get access to the npm 2FA secret for the eslint account. It also updates the release guidelines to account for the 2FA step.

Is there anything you'd like reviewers to focus on?

If you're on the TSC and you haven't set up Keybase yet, it might be useful to use these instructions to get set up, and point out any issues you encounter with the instructions.

@kaicataldo
Copy link
Member

left a comment

Thanks for setting this all up!

@platinumazure
Copy link
Member

left a comment

LGTM, and the instructions were very clear. Thanks!

@not-an-aardvark not-an-aardvark merged commit 58ff359 into master Oct 19, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the update-2fa-instructions branch Oct 19, 2018

@eslint eslint bot locked and limited conversation to collaborators Apr 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.