Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update rule message of no-throw-literal (fixes #11637) #11638

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@g-plane
Copy link
Member

commented Apr 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #11637

Is there anything you'd like reviewers to focus on?
Maybe no.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks! Would love to have a second set of eyes on this to make sure the overall direction makes sense.

@aladdin-add
Copy link
Member

left a comment

would you add a test like throw { foo: 'bar' }; (if it was no covered)?

otherwise LGTM. thanks!

@not-an-aardvark not-an-aardvark merged commit 776b0fe into master Apr 30, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the issue-11637 branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.