Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add eslint as a devDependeny #11654

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@mysticatea
Copy link
Member

commented Apr 26, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: add eslint to devDependencies

What changes did you make? (Give an overview)

This PR adds eslint to devDepndencies.

+     "eslint": "file:.",

From this, npm makes a symbolic link ./node_modules/eslint./ so editors such as VSCode can use it to lint our codebase.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@aladdin-add

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

"node ./bin/eslint.js --fix",

also, this line can be "eslint --fix", (if I'm not misunderstanding). 😄

@mysticatea mysticatea merged commit 7f290a9 into master Apr 30, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the eslint-as-a-dev-dependency branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.