Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: consider comments in object-curly-spacing (fixes #11656) #11657

Merged
merged 1 commit into from Apr 30, 2019
Merged

Fix: consider comments in object-curly-spacing (fixes #11656) #11657

merged 1 commit into from Apr 30, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Apr 27, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #11656

Is there anything you'd like reviewers to focus on?
No.

@g-plane g-plane added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Apr 27, 2019
aladdin-add
aladdin-add approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 67c08b6 into master Apr 30, 2019
@not-an-aardvark not-an-aardvark deleted the issue-11656 branch April 30, 2019 04:49
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 28, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

object-curly-spacing warns on trailing comments, fixer deletes
4 participants
@g-plane @platinumazure @aladdin-add @not-an-aardvark