Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove incorrect comment #11769

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
2 participants
@aladdin-add
Copy link
Member

commented May 26, 2019

it is no longer needed, as #11742 get merged. :)

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

not really.

Chore: remove incorrect comment
it is no longer needed, as #11742 get merged. :)
@mysticatea
Copy link
Member

left a comment

LGTM, but I'm happy if you update the JSDoc comment @returns {Rule} ... to @returns {Rule|null} ... additionally.

@aladdin-add aladdin-add merged commit 8eaa9b2 into master May 27, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@aladdin-add aladdin-add deleted the chore/remove-comment branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.