-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: require-atomic-updates reports parameters (fixes #11723) #11774
Conversation
Could you give an example of the problems with closures? |
In general, we cannot distinguish if a closure will be run in sync or async. Hm, but indeed, I don't have ideas about concrete examples. I will revert that change. We can defer the change until a bug report with a concrete situation. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Friendly ping: @not-an-aardvark, did you want to review this after @mysticatea addressed your original question? |
Sorry, I haven't had time to review, but feel free to merge this if you/others are satisfied with the changes (i.e. don't let me be a blocker). |
I'll merge this PR. Thank you! |
3768: Update eslint to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.16.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> Upgrade: espree@6.0.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="459423824" data-permission-text="Issue title is private" data-url="eslint/eslint#11869" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11869/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11869">#11869</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> Fix: no-else-return autofix produces name collisions (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="379034848" data-permission-text="Issue title is private" data-url="eslint/eslint#11069" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11069/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11069">#11069</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458936519" data-permission-text="Issue title is private" data-url="eslint/eslint#11867" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11867/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11867">#11867</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> Fix: multiline-comment-style incorrect message (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458734961" data-permission-text="Issue title is private" data-url="eslint/eslint#11864" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11864/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11864">#11864</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> Docs: Add JSHint W047 compat to no-floating-decimal (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458263641" data-permission-text="Issue title is private" data-url="eslint/eslint#11861" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11861/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11861">#11861</a>) (Timo Tijhof)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> Upgrade: sinon (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457291043" data-permission-text="Issue title is private" data-url="eslint/eslint#11855" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11855/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11855">#11855</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> Chore: remove unuseable profile command (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457263136" data-permission-text="Issue title is private" data-url="eslint/eslint#11854" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11854/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11854">#11854</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> Fix: max-len properly ignore trailing comments (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456296209" data-permission-text="Issue title is private" data-url="eslint/eslint#11838" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11838/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11838">#11838</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456541689" data-permission-text="Issue title is private" data-url="eslint/eslint#11841" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11841/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11841">#11841</a>) (ZYSzys)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> Fix: no-var should not fix variables named 'let' (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455497836" data-permission-text="Issue title is private" data-url="eslint/eslint#11830" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11830/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11830">#11830</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455842715" data-permission-text="Issue title is private" data-url="eslint/eslint#11832" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11832/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11832">#11832</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> Build: CI with Azure Pipelines (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456633314" data-permission-text="Issue title is private" data-url="eslint/eslint#11845" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11845/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11845">#11845</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> Chore: rm superfluous argument & fix perf-multifiles-targets (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456083357" data-permission-text="Issue title is private" data-url="eslint/eslint#11834" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11834/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11834">#11834</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> Upgrade: @babel/polyfill => core-js v3 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456082991" data-permission-text="Issue title is private" data-url="eslint/eslint#11833" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11833/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11833">#11833</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> Docs: Clarify prefer-destructuring array/object difference (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="296847330" data-permission-text="Issue title is private" data-url="eslint/eslint#9970" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9970/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9970">#9970</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456862527" data-permission-text="Issue title is private" data-url="eslint/eslint#11851" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11851/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11851">#11851</a>) (Oliver Sieweke)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> Fix: require-atomic-updates reports parameters (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="444325566" data-permission-text="Issue title is private" data-url="eslint/eslint#11723" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11723/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11723">#11723</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="448642807" data-permission-text="Issue title is private" data-url="eslint/eslint#11774" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11774/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11774">#11774</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/aef8ea1a44b9f13d468f48536c4c93f79f201d9b"><code>aef8ea1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 134 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a7985a6a6ba3d800194f20faf94f5efb9282a360"><code>a7985a6</code></a> <code>6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/be74dd9f98527bdf9af568d25c0eb7ca435b21a1"><code>be74dd9</code></a> <code>Build: changelog update for 6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> <code>Upgrade: espree@6.0.0 (#11869)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> <code>Fix: no-else-return autofix produces name collisions (fixes #11069) (#11867)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> <code>Fix: multiline-comment-style incorrect message (#11864)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> <code>Docs: Add JSHint W047 compat to no-floating-decimal (#11861)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> <code>Upgrade: sinon (#11855)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> <code>Chore: remove unuseable profile command (#11854)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> <code>Fix: max-len properly ignore trailing comments (fixes #11838) (#11841)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> <code>Fix: no-var should not fix variables named 'let' (fixes #11830) (#11832)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> <code>Build: CI with Azure Pipelines (#11845)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> <code>Chore: rm superfluous argument & fix perf-multifiles-targets (#11834)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> <code>Upgrade: @babel/polyfill => core-js v3 (#11833)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> <code>Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> <code>Fix: require-atomic-updates reports parameters (fixes #11723) (#11774)</code></li> </ul> <p>There are 134 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/ded2f94758545c7f895f5f848a805b420f41f415...a7985a6a6ba3d800194f20faf94f5efb9282a360">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
3768: Update eslint to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.16.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> Upgrade: espree@6.0.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="459423824" data-permission-text="Issue title is private" data-url="eslint/eslint#11869" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11869/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11869">#11869</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> Fix: no-else-return autofix produces name collisions (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="379034848" data-permission-text="Issue title is private" data-url="eslint/eslint#11069" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11069/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11069">#11069</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458936519" data-permission-text="Issue title is private" data-url="eslint/eslint#11867" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11867/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11867">#11867</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> Fix: multiline-comment-style incorrect message (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458734961" data-permission-text="Issue title is private" data-url="eslint/eslint#11864" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11864/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11864">#11864</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> Docs: Add JSHint W047 compat to no-floating-decimal (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458263641" data-permission-text="Issue title is private" data-url="eslint/eslint#11861" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11861/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11861">#11861</a>) (Timo Tijhof)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> Upgrade: sinon (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457291043" data-permission-text="Issue title is private" data-url="eslint/eslint#11855" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11855/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11855">#11855</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> Chore: remove unuseable profile command (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457263136" data-permission-text="Issue title is private" data-url="eslint/eslint#11854" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11854/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11854">#11854</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> Fix: max-len properly ignore trailing comments (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456296209" data-permission-text="Issue title is private" data-url="eslint/eslint#11838" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11838/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11838">#11838</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456541689" data-permission-text="Issue title is private" data-url="eslint/eslint#11841" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11841/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11841">#11841</a>) (ZYSzys)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> Fix: no-var should not fix variables named 'let' (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455497836" data-permission-text="Issue title is private" data-url="eslint/eslint#11830" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11830/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11830">#11830</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455842715" data-permission-text="Issue title is private" data-url="eslint/eslint#11832" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11832/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11832">#11832</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> Build: CI with Azure Pipelines (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456633314" data-permission-text="Issue title is private" data-url="eslint/eslint#11845" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11845/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11845">#11845</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> Chore: rm superfluous argument & fix perf-multifiles-targets (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456083357" data-permission-text="Issue title is private" data-url="eslint/eslint#11834" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11834/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11834">#11834</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> Upgrade: @babel/polyfill => core-js v3 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456082991" data-permission-text="Issue title is private" data-url="eslint/eslint#11833" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11833/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11833">#11833</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> Docs: Clarify prefer-destructuring array/object difference (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="296847330" data-permission-text="Issue title is private" data-url="eslint/eslint#9970" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9970/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9970">#9970</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456862527" data-permission-text="Issue title is private" data-url="eslint/eslint#11851" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11851/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11851">#11851</a>) (Oliver Sieweke)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> Fix: require-atomic-updates reports parameters (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="444325566" data-permission-text="Issue title is private" data-url="eslint/eslint#11723" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11723/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11723">#11723</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="448642807" data-permission-text="Issue title is private" data-url="eslint/eslint#11774" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11774/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11774">#11774</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/aef8ea1a44b9f13d468f48536c4c93f79f201d9b"><code>aef8ea1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 134 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a7985a6a6ba3d800194f20faf94f5efb9282a360"><code>a7985a6</code></a> <code>6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/be74dd9f98527bdf9af568d25c0eb7ca435b21a1"><code>be74dd9</code></a> <code>Build: changelog update for 6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> <code>Upgrade: espree@6.0.0 (#11869)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> <code>Fix: no-else-return autofix produces name collisions (fixes #11069) (#11867)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> <code>Fix: multiline-comment-style incorrect message (#11864)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> <code>Docs: Add JSHint W047 compat to no-floating-decimal (#11861)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> <code>Upgrade: sinon (#11855)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> <code>Chore: remove unuseable profile command (#11854)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> <code>Fix: max-len properly ignore trailing comments (fixes #11838) (#11841)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> <code>Fix: no-var should not fix variables named 'let' (fixes #11830) (#11832)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> <code>Build: CI with Azure Pipelines (#11845)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> <code>Chore: rm superfluous argument & fix perf-multifiles-targets (#11834)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> <code>Upgrade: @babel/polyfill => core-js v3 (#11833)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> <code>Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> <code>Fix: require-atomic-updates reports parameters (fixes #11723) (#11774)</code></li> </ul> <p>There are 134 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/ded2f94758545c7f895f5f848a805b420f41f415...a7985a6a6ba3d800194f20faf94f5efb9282a360">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
3768: Update eslint to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.16.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> Upgrade: espree@6.0.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="459423824" data-permission-text="Issue title is private" data-url="eslint/eslint#11869" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11869/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11869">#11869</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> Fix: no-else-return autofix produces name collisions (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="379034848" data-permission-text="Issue title is private" data-url="eslint/eslint#11069" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11069/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11069">#11069</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458936519" data-permission-text="Issue title is private" data-url="eslint/eslint#11867" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11867/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11867">#11867</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> Fix: multiline-comment-style incorrect message (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458734961" data-permission-text="Issue title is private" data-url="eslint/eslint#11864" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11864/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11864">#11864</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> Docs: Add JSHint W047 compat to no-floating-decimal (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458263641" data-permission-text="Issue title is private" data-url="eslint/eslint#11861" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11861/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11861">#11861</a>) (Timo Tijhof)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> Upgrade: sinon (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457291043" data-permission-text="Issue title is private" data-url="eslint/eslint#11855" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11855/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11855">#11855</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> Chore: remove unuseable profile command (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457263136" data-permission-text="Issue title is private" data-url="eslint/eslint#11854" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11854/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11854">#11854</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> Fix: max-len properly ignore trailing comments (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456296209" data-permission-text="Issue title is private" data-url="eslint/eslint#11838" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11838/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11838">#11838</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456541689" data-permission-text="Issue title is private" data-url="eslint/eslint#11841" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11841/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11841">#11841</a>) (ZYSzys)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> Fix: no-var should not fix variables named 'let' (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455497836" data-permission-text="Issue title is private" data-url="eslint/eslint#11830" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11830/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11830">#11830</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455842715" data-permission-text="Issue title is private" data-url="eslint/eslint#11832" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11832/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11832">#11832</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> Build: CI with Azure Pipelines (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456633314" data-permission-text="Issue title is private" data-url="eslint/eslint#11845" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11845/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11845">#11845</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> Chore: rm superfluous argument & fix perf-multifiles-targets (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456083357" data-permission-text="Issue title is private" data-url="eslint/eslint#11834" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11834/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11834">#11834</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> Upgrade: @babel/polyfill => core-js v3 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456082991" data-permission-text="Issue title is private" data-url="eslint/eslint#11833" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11833/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11833">#11833</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> Docs: Clarify prefer-destructuring array/object difference (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="296847330" data-permission-text="Issue title is private" data-url="eslint/eslint#9970" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9970/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9970">#9970</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456862527" data-permission-text="Issue title is private" data-url="eslint/eslint#11851" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11851/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11851">#11851</a>) (Oliver Sieweke)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> Fix: require-atomic-updates reports parameters (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="444325566" data-permission-text="Issue title is private" data-url="eslint/eslint#11723" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11723/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11723">#11723</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="448642807" data-permission-text="Issue title is private" data-url="eslint/eslint#11774" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11774/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11774">#11774</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/aef8ea1a44b9f13d468f48536c4c93f79f201d9b"><code>aef8ea1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 134 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a7985a6a6ba3d800194f20faf94f5efb9282a360"><code>a7985a6</code></a> <code>6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/be74dd9f98527bdf9af568d25c0eb7ca435b21a1"><code>be74dd9</code></a> <code>Build: changelog update for 6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> <code>Upgrade: espree@6.0.0 (#11869)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> <code>Fix: no-else-return autofix produces name collisions (fixes #11069) (#11867)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> <code>Fix: multiline-comment-style incorrect message (#11864)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> <code>Docs: Add JSHint W047 compat to no-floating-decimal (#11861)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> <code>Upgrade: sinon (#11855)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> <code>Chore: remove unuseable profile command (#11854)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> <code>Fix: max-len properly ignore trailing comments (fixes #11838) (#11841)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> <code>Fix: no-var should not fix variables named 'let' (fixes #11830) (#11832)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> <code>Build: CI with Azure Pipelines (#11845)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> <code>Chore: rm superfluous argument & fix perf-multifiles-targets (#11834)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> <code>Upgrade: @babel/polyfill => core-js v3 (#11833)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> <code>Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> <code>Fix: require-atomic-updates reports parameters (fixes #11723) (#11774)</code></li> </ul> <p>There are 134 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/ded2f94758545c7f895f5f848a805b420f41f415...a7985a6a6ba3d800194f20faf94f5efb9282a360">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
3768: Update eslint to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.16.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> Upgrade: espree@6.0.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="459423824" data-permission-text="Issue title is private" data-url="eslint/eslint#11869" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11869/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11869">#11869</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> Fix: no-else-return autofix produces name collisions (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="379034848" data-permission-text="Issue title is private" data-url="eslint/eslint#11069" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11069/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11069">#11069</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458936519" data-permission-text="Issue title is private" data-url="eslint/eslint#11867" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11867/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11867">#11867</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> Fix: multiline-comment-style incorrect message (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458734961" data-permission-text="Issue title is private" data-url="eslint/eslint#11864" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11864/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11864">#11864</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> Docs: Add JSHint W047 compat to no-floating-decimal (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="458263641" data-permission-text="Issue title is private" data-url="eslint/eslint#11861" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11861/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11861">#11861</a>) (Timo Tijhof)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> Upgrade: sinon (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457291043" data-permission-text="Issue title is private" data-url="eslint/eslint#11855" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11855/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11855">#11855</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> Chore: remove unuseable profile command (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="457263136" data-permission-text="Issue title is private" data-url="eslint/eslint#11854" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11854/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11854">#11854</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> Fix: max-len properly ignore trailing comments (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456296209" data-permission-text="Issue title is private" data-url="eslint/eslint#11838" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11838/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11838">#11838</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456541689" data-permission-text="Issue title is private" data-url="eslint/eslint#11841" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11841/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11841">#11841</a>) (ZYSzys)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> Fix: no-var should not fix variables named 'let' (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455497836" data-permission-text="Issue title is private" data-url="eslint/eslint#11830" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11830/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11830">#11830</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="455842715" data-permission-text="Issue title is private" data-url="eslint/eslint#11832" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11832/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11832">#11832</a>) (Milos Djermanovic)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> Build: CI with Azure Pipelines (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456633314" data-permission-text="Issue title is private" data-url="eslint/eslint#11845" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11845/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11845">#11845</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> Chore: rm superfluous argument & fix perf-multifiles-targets (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456083357" data-permission-text="Issue title is private" data-url="eslint/eslint#11834" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11834/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11834">#11834</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> Upgrade: @babel/polyfill => core-js v3 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456082991" data-permission-text="Issue title is private" data-url="eslint/eslint#11833" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11833/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11833">#11833</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> Docs: Clarify prefer-destructuring array/object difference (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="296847330" data-permission-text="Issue title is private" data-url="eslint/eslint#9970" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9970/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9970">#9970</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="456862527" data-permission-text="Issue title is private" data-url="eslint/eslint#11851" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11851/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11851">#11851</a>) (Oliver Sieweke)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> Fix: require-atomic-updates reports parameters (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="444325566" data-permission-text="Issue title is private" data-url="eslint/eslint#11723" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11723/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11723">#11723</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="448642807" data-permission-text="Issue title is private" data-url="eslint/eslint#11774" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11774/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11774">#11774</a>) (Toru Nagashima)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/aef8ea1a44b9f13d468f48536c4c93f79f201d9b"><code>aef8ea1</code></a> Sponsors: Sync README with website (ESLint Jenkins)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 134 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a7985a6a6ba3d800194f20faf94f5efb9282a360"><code>a7985a6</code></a> <code>6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/be74dd9f98527bdf9af568d25c0eb7ca435b21a1"><code>be74dd9</code></a> <code>Build: changelog update for 6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81aa06b4cc49e9c15234a2c4d27659a03fea53d8"><code>81aa06b</code></a> <code>Upgrade: espree@6.0.0 (#11869)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5f022bc91d0d93d140876ceb1ee4e08b1b7cfd49"><code>5f022bc</code></a> <code>Fix: no-else-return autofix produces name collisions (fixes #11069) (#11867)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ded9548d881b15e771ca79b844e8159601f30f70"><code>ded9548</code></a> <code>Fix: multiline-comment-style incorrect message (#11864)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/cad074d4ddb34a59183b5965ca50170713b5a711"><code>cad074d</code></a> <code>Docs: Add JSHint W047 compat to no-floating-decimal (#11861)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/41f6304ce641a82ee729251b448dceb9fb0d501d"><code>41f6304</code></a> <code>Upgrade: sinon (#11855)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/167ce87e908ec04b0d3d79960278d45c883c4285"><code>167ce87</code></a> <code>Chore: remove unuseable profile command (#11854)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c844c6f2ff314cfa8c6ca0e35a1ef58b7e297b79"><code>c844c6f</code></a> <code>Fix: max-len properly ignore trailing comments (fixes #11838) (#11841)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1b5661ae467c227c0239e06cc1466480004aa799"><code>1b5661a</code></a> <code>Fix: no-var should not fix variables named 'let' (fixes #11830) (#11832)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4d75956147b6fd662ee90eb21d3f762816463b88"><code>4d75956</code></a> <code>Build: CI with Azure Pipelines (#11845)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1db346220889305a427b45a00afcf362b81b3767"><code>1db3462</code></a> <code>Chore: rm superfluous argument & fix perf-multifiles-targets (#11834)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c57a4a4a993193c4208c6419df331a7bc644a536"><code>c57a4a4</code></a> <code>Upgrade: @babel/polyfill => core-js v3 (#11833)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/65faa04e8b42eecd4505111bbff296951179f033"><code>65faa04</code></a> <code>Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/81c382378923a45015bafe58362f6c8faa5c3d5f"><code>81c3823</code></a> <code>Fix: require-atomic-updates reports parameters (fixes #11723) (#11774)</code></li> </ul> <p>There are 134 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/ded2f94758545c7f895f5f848a805b420f41f415...a7985a6a6ba3d800194f20faf94f5efb9282a360">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #11723
But the resolution is different from the original report. The report was a false positive, but this is a false negative. (See also #11723 (comment))
What changes did you make? (Give an overview)
This PR changes
require-atomic-updates
behavior.Makes the closure handling relax because it causes a ton of false positive. We cannot know if the closure will be run sync or async. If the synchronous callbacks such asArray#map
triggerrequire-atomic-updates
errors, it will confuse people. Since the rule is ineslint:recommended
, it's better if false negative is less.a295496 and 4e845fd are the change. This PR contains a few refactoring.
Is there anything you'd like reviewers to focus on?
Is this direction is right?
Especially, about the closure handling relaxing. Do you have another idea to reduce false positive?