Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: removes unnecessary assignment in loop #11780

Merged
merged 2 commits into from Jun 8, 2019

Conversation

Projects
None yet
5 participants
@dimitropoulos
Copy link
Contributor

commented May 29, 2019

also reduces cyclomatic complexity with a slight reconfiguring of some conditions

What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
see below

What changes did you make? (Give an overview)
I noticed that this code could be a tad bit improved by removing the assignment that was inside the for loop. I also reduced the complexity of the bottom bit slightly.

Is there anything you'd like reviewers to focus on?
it's a very small change. no.

@eslint eslint bot added the triage label May 29, 2019

@kaicataldo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Thanks for the PR. Mind fixing the errors that are causing CI to fail so we can take a look?

@kaicataldo kaicataldo added chore and removed triage labels May 29, 2019

Chore: removes unnecessary assignment in loop
also reduces cyclomatic complexity with a slight reconfiguring of some conditions

@dimitropoulos dimitropoulos force-pushed the dimitropoulos:patch-3 branch from 978fcc5 to f00b9ff May 29, 2019

@dimitropoulos

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@kaicataldo sorry 'bout that, made the change in github and it didn't show me the whitespace like I'm used to in my editor. should be fixed now.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure platinumazure requested a review from ilyavolodin Jun 8, 2019

@ilyavolodin ilyavolodin merged commit e0fafc8 into eslint:master Jun 8, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.