Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: `overrides` handle relative paths as expected (fixes #11577) #11799

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@mysticatea
Copy link
Member

commented Jun 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix #11577

What changes did you make? (Give an overview)

This PR fixes overrides[].files and overrides[].excludedFiles to handle ./ as expected.

The change is below. Especially, we newly can specify ./*.js-like patterns that match with the files in the root directory but not in subdirectories.

Pattern FilePath Before After Fixed
*.js foo.js true true
*.js dir/foo.js true true
./*.js foo.js false true
./*.js dir/foo.js false false
dir/*.js foo.js false false
dir/*.js dir/foo.js true true
./dir/*.js foo.js false false
./dir/*.js dir/foo.js false true

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@platinumazure
Copy link
Member

left a comment

LGTM, thanks!

@g-plane

g-plane approved these changes Jun 3, 2019

Copy link
Member

left a comment

LGTM, thanks!

@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@mysticatea mysticatea merged commit 21f3131 into master Jun 5, 2019

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the issue11577 branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.