Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use GitHub Actions #12144

Merged
merged 9 commits into from Aug 30, 2019
Merged

Chore: use GitHub Actions #12144

merged 9 commits into from Aug 30, 2019

Conversation

@mysticatea
Copy link
Member

mysticatea commented Aug 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: Trial GitHub Actions

What changes did you make? (Give an overview)

This PR set up GitHub Actions for CI.

GitHub Actions works on Azure that is the current our CI.

There are some cons:

  • It doesn't provide build badge. (E.g., Azure Pipelines provide Build Status)
  • It doesn't provide the detail of tests. (E.g., Azure Pipelines provide the Tests Tab)
  • It doesn't provide the detail of code coverage. (E.g., Azure Pipelines provide the Code Coverage Tab)

Is there anything you'd like reviewers to focus on?

Do we want to switch CI platform?

mysticatea added 6 commits Aug 22, 2019
@mysticatea mysticatea changed the title [Trial] Chore: use GitHub Actions Chore: use GitHub Actions Aug 22, 2019
@kaicataldo

This comment has been minimized.

Copy link
Member

kaicataldo commented Aug 22, 2019

I'm supportive of switching over to GitHub actions 👍 Seems like we might be able to leverage them for other tasks as well.

@g-plane

This comment has been minimized.

Copy link
Member

g-plane commented Aug 23, 2019

I think GitHub Actions provides badges. See an example: https://github.com/yarnpkg/berry/blob/master/README.md

@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Aug 23, 2019

@g-plane Thank you! I have added the badge, but it doesn't seem to exist until merged.

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Aug 26, 2019

Thanks for putting this together, @mysticatea!

Are there any benefits to switching to GitHub Actions at this time? So far, I've only seen cons identified in this issue. 😄

@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Aug 27, 2019

I think the pro is that we don't need to depend on external services.

And in the future, I guess that we can aggregate CI and other workflows (commit message validator, release cycle monitor, "needs info" label handler, and auto-closer of issues) into GitHub Actions. If it was realized, probably we can reduce the maintenance cost of infrastructure.

@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Aug 27, 2019

TSC Summary

This PR switches our CI to GitHub Actions from Azure Pipelines.

Pros:

  • We don't need to depend on external services for CI.
  • I guess that we can aggregate CI and other workflows (commit message validator, release cycle monitor, "needs info" label handler, and auto-closer of issues) into GitHub Actions. If it was realized, probably we can reduce the maintenance cost of infrastructure.

Cons:

  • It's still beta.
  • It doesn't provide the detail of tests. (E.g., Azure Pipelines provide the Tests Tab)
  • It doesn't provide the detail of code coverage. (E.g., Azure Pipelines provide the Code Coverage Tab)

TSC Question

Should we switch CI?

@mysticatea mysticatea removed the tsc agenda label Aug 30, 2019
@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Aug 30, 2019

TSC Resolution: We add GitHub Actions beside with Azure Pipelines, then evaluate it. If GitHub Actions gets stable and we find that it's good enough, we will complete switching. Meeting Notes.

@mysticatea mysticatea added accepted and removed evaluating labels Aug 30, 2019
@mysticatea

This comment has been minimized.

Copy link
Member Author

mysticatea commented Aug 30, 2019

I have re-added files of Azure Pipelines.

Copy link
Member

kaicataldo left a comment

LGTM!

@btmills btmills merged commit 94e39d9 into master Aug 30, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration Build #20190830.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.