Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change "Code Conventions" link in pull-requests.md #12401

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@gamtiq
Copy link
Contributor

gamtiq commented Oct 10, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixed broken link.

Is there anything you'd like reviewers to focus on?

No.

@eslint eslint bot added the triage label Oct 10, 2019
@g-plane
Copy link
Member

g-plane commented Oct 10, 2019

While I'm not opposed to this changes, that link isn't broken.

@kaicataldo
Copy link
Member

kaicataldo commented Oct 10, 2019

I do think it would be nice to be consistent in our documentation. Perhaps we should do this for all the relative links (i.e. links for eslint.org) and switch them to .md)? This allows the Markdown files to also link correctly in the GitHub view as well as the generated site.

@kaicataldo kaicataldo added chore evaluating and removed triage labels Oct 10, 2019
@aladdin-add aladdin-add changed the title Fix: Change "Code Conventions" link in pull-requests.md Docs: Change "Code Conventions" link in pull-requests.md Nov 13, 2019
@aladdin-add
Copy link
Member

aladdin-add commented Nov 15, 2019

well, I think it's fine to merge as-is.

@kaicataldo what do you like to create a new issue to talk about it?

@aladdin-add aladdin-add merged commit 0a480f8 into eslint:master Nov 15, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x) Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x) Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x) Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x) Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x) Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191010.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@gamtiq gamtiq deleted the gamtiq:patch-1 branch Nov 17, 2019
@eslint eslint bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.