Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: enforceForNewInMemberExpressions no-extra-parens (fixes #12428) #12436

Merged
merged 1 commit into from Oct 20, 2019

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Changes an existing rule #12428

What rule do you want to change?

no-extra-parens

Does this change cause the rule to produce more or fewer warnings?

Fewer if the option is set to false. Default is true.

How will the change be implemented? (New option, new default behavior, etc.)?

new option enforceForNewInMemberExpressions

Please provide some example code that this change will affect:

/* eslint no-extra-parens: "error" */

const foo = (new Bar()).baz; // error

const quux = (new Bar())[baz]; // error

(new Bar()).doSomething(); // error

What does the rule currently do for this code?

3 errors.

What will the rule do after it's changed?

No errors if the option is set to false:

/* eslint no-extra-parens: ["error", "all", { "enforceForNewInMemberExpressions": false }] */

const foo = (new Bar()).baz; // ok

const quux = (new Bar())[baz]; // ok

(new Bar()).doSomething(); // ok

What changes did you make? (Give an overview)

New option.

Is there anything you'd like reviewers to focus on?

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit 6e7c18d into master Oct 20, 2019
16 checks passed
16 checks passed
Verify Files
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191015.1 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure platinumazure deleted the issue12428 branch Oct 20, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants