Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: require-await crash on global await #12571

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@bradzacher
Copy link
Contributor

bradzacher commented Nov 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix (template)

What changes did you make? (Give an overview)

@typescript-eslint/parser allows global awaits.
This currently rule assumes that is not allowed, because espree throws a parsing error on it.

This PR just stops the rule from crashing on global await statements.

Related: typescript-eslint/typescript-eslint#1077

@eslint eslint bot added the triage label Nov 15, 2019
@platinumazure platinumazure added accepted bug rule and removed triage labels Nov 15, 2019
Copy link
Member

platinumazure left a comment

Can you add a test which will trigger the for-await-of in top-level scope? Otherwise it seems that the change in ForOfStatement might not be needed.

@bradzacher bradzacher force-pushed the bradzacher:fix-require-await branch from 59667e2 to 2b0d496 Nov 15, 2019
@bradzacher
Copy link
Contributor Author

bradzacher commented Nov 15, 2019

I was being lazy. Thanks for not letting me 😄
Fixed

@kaicataldo
Copy link
Member

kaicataldo commented Nov 15, 2019

For posterity, top-level await is stage 3 at this time and it is ESLint’s policy to fix rules that crash on stage 3 features.

Copy link
Member

kaicataldo left a comment

LGTM, thanks!

@platinumazure platinumazure merged commit fed20bb into eslint:master Nov 15, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191115.6 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@platinumazure
Copy link
Member

platinumazure commented Nov 15, 2019

Thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.