Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove references to parser demo #12644

Merged
merged 1 commit into from Dec 6, 2019
Merged

Chore: remove references to parser demo #12644

merged 1 commit into from Dec 6, 2019

Conversation

@kaicataldo
Copy link
Member

kaicataldo commented Dec 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

In addition to the documentation update, this PR also removes the bundling of espree, since it's only used for the parser demo.

refs eslint/website#652

What changes did you make? (Give an overview)
Following up on eslint/website#664, this PR does two things:

  1. Remove the bundling of Espree in eslint/eslint.
  2. Replace instances of referring users to the parser with links to AST Explorer instead.

We should probably land the eslint/website PR first, but since we're a ways out from our next release we should be okay as long as we can follow up with merging this shortly after.

Is there anything you'd like reviewers to focus on?
Nothing in particular.

@eslint eslint bot added the triage label Dec 5, 2019
@kaicataldo kaicataldo added chore accepted and removed triage labels Dec 5, 2019
@kaicataldo kaicataldo force-pushed the remove-parser-demo branch from f9a179e to d763f61 Dec 5, 2019
@btmills
btmills approved these changes Dec 5, 2019
@kaicataldo kaicataldo merged commit 8b65f17 into master Dec 6, 2019
18 checks passed
18 checks passed
Verify Files
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 8.x)
Details
Test (ubuntu-latest, 8.10.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
continuous-integration Build #20191205.4 succeeded
Details
continuous-integration (Test on Node.js 10 (Linux)) Test on Node.js 10 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Linux)) Test on Node.js 12 (Linux) succeeded
Details
continuous-integration (Test on Node.js 12 (Windows)) Test on Node.js 12 (Windows) succeeded
Details
continuous-integration (Test on Node.js 12 (macOS)) Test on Node.js 12 (macOS) succeeded
Details
continuous-integration (Test on Node.js 8 (Linux)) Test on Node.js 8 (Linux) succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@kaicataldo kaicataldo deleted the remove-parser-demo branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.