Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor links #13715

Merged
merged 1 commit into from Oct 7, 2020
Merged

Fix anchor links #13715

merged 1 commit into from Oct 7, 2020

Conversation

gmoore
Copy link
Contributor

@gmoore gmoore commented Sep 24, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix anchor links to LintResult, LintMessage, EditInfo, and Formatter

Is there anything you'd like reviewers to focus on?

No

Fix anchor links to LintResult, LintMessage, EditInfo, and Formatter
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Sep 24, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage label Sep 24, 2020
@mdjermanovic mdjermanovic added accepted documentation and removed triage labels Sep 25, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Thanks for the PR! Those four links are indeed broken.

docs/developer-guide/nodejs-api.md Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Note to merger: commit message should start with Docs:

btmills
btmills approved these changes Oct 7, 2020
Copy link
Member

@btmills btmills left a comment

LGTM. Thanks for fixing these @gmoore!

@btmills btmills merged commit ab0ac6c into eslint:master Oct 7, 2020
11 of 12 checks passed
btmills added a commit that referenced this issue Oct 7, 2020
This is a partial follow-up to some future work pointed out by
@mdjermanovic in #13715. @mdjermanovic, feel free to take over this
branch or close this PR in favor of another that does this as part of
the more complete update you had in mind.
mdjermanovic pushed a commit that referenced this issue Oct 9, 2020
)

This is a partial follow-up to some future work pointed out by
@mdjermanovic in #13715. @mdjermanovic, feel free to take over this
branch or close this PR in favor of another that does this as part of
the more complete update you had in mind.
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Apr 6, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants