Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix false negative of no-extra-parens with NewExpression #13930

Merged
merged 1 commit into from Dec 18, 2020

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Dec 16, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

This bug fix can generate more warnings.

Tell us about your environment

  • ESLint Version: v7.15.0
  • Node Version: v12.18.4
  • npm Version: v6.14.6

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using?

Please show your full configuration:

Configuration
module.exports = {
  parserOptions: {
    ecmaVersion: 2015
  }
};

What did you do? Please include the actual source code causing the issue.

Online Demo

/* eslint no-extra-parens: error */

new (new A);

What did you expect to happen?

Given that no-extra-parens already reports new (new A())() as in this demo, I would expect an error and autofix to:

/* eslint no-extra-parens: error */

new new A;

What actually happened? Please include the actual, raw output from ESLint.

no errors

What changes did you make? (Give an overview)

Fixed the no-extra-parens rule to not skip NewExpression without parens of arguments when the parent NewExpression also doesn't have those parens.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug rule accepted labels Dec 16, 2020
!(
node.type === "NewExpression" &&
!isNewExpressionWithParens(node)
)
Copy link
Member Author

@mdjermanovic mdjermanovic Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, the rest of the diff is refactoring.

invalid("new (new A);", "new new A;", "NewExpression"),
invalid("new (new a.b);", "new new a.b;", "NewExpression"),
Copy link
Member Author

@mdjermanovic mdjermanovic Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests are new behavior, others are regression tests.

Copy link
Member

@btmills btmills left a comment

The if condition has too many branches for me to be 100% confident I'm following correctly, so thanks for adding the comments, and I'll rely on the tests to prove the behavior is correct. LGTM

@mdjermanovic mdjermanovic merged commit a62ad6f into master Dec 18, 2020
13 checks passed
@mdjermanovic mdjermanovic deleted the noextraparens-newnewcallee branch Dec 18, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 17, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants