Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-mixed-operators false positives with ? : (fixes #14223) #14226

Merged
merged 1 commit into from Mar 24, 2021

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #14223

Fixes false positives such as:

/* eslint no-mixed-operators: ["error", { groups: [["&&", "||", "?:"]] }] */

a ? (b || c) : d; // false positive

(a) ? (b || c) : d; // ok

(a ? (b || c) : d); // also ok

//--------------------------------

a ? b : (c || d); // false positive

(a) ? b : (c || d); // ok

(a ? b : (c || d)); // also ok

What changes did you make? (Give an overview)

Removed invalid isMixedWithConditionalParent() check.

The other check, isMixedWithParent(), already covers binary/logical expression nodes in conditional expressions, so !astUtils.isParenthesised(sourceCode, node.test) condition in isMixedWithConditionalParent() was redundant for child binary/logical expressions in test, and wrong for child binary/logical expressions in consequent/alternate.

!astUtils.isParenthesised(sourceCode, node) condition in isMixedWithConditionalParent() was also wrong. It gets a ConditionalExpression node when its child binary/logical expression node is being checked, so checking parens around the ConditionalExpression in that case doesn't make sense.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 17, 2021
nzakas
nzakas approved these changes Mar 20, 2021
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdjermanovic mdjermanovic merged commit 28583eb into master Mar 24, 2021
13 checks passed
@mdjermanovic mdjermanovic deleted the issue14223 branch Mar 24, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 21, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-mixed-operators: don't require parentheses around a single ternary operator argument
3 participants