Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade mocha to 8.3.2

merged 1 commit into from Apr 1, 2021


Copy link

@stephenwade stephenwade commented Mar 31, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Dev tooling update (Upgrades mocha to the latest version to fix deprecation warnings when running npm install in the ESLint repo).

What changes did you make? (Give an overview)

I upgraded mocha and mocha-junit-reporter to the latest versions.

Is there anything you'd like reviewers to focus on?

I believe we are not affected by any of Mocha's breaking changes in version 8, and the tests work on my machine, but I'd like a second look at that.

Mocha v8.0.0 release notes

A potential next step would be testing the new parallel tests feature in Mocha 8.

@eslint-github-bot eslint-github-bot bot added the triage label Mar 31, 2021
nzakas approved these changes Apr 1, 2021
Copy link

@nzakas nzakas left a comment

LGTM. Thanks.

@nzakas nzakas merged commit c981fb1 into eslint:master Apr 1, 2021
13 checks passed
@stephenwade stephenwade deleted the update-mocha-8 branch Apr 22, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 29, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
archived due to age triage
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants