Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: create .eslintrc.cjs for module type #14304

Merged
merged 7 commits into from May 6, 2021
Merged

Conversation

@snitin315
Copy link
Contributor

@snitin315 snitin315 commented Apr 9, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fixes #14137

Is there anything you'd like reviewers to focus on?

NO

@snitin315 snitin315 force-pushed the fix/init branch 5 times, most recently from 50ad7ae to e166e7d Apr 9, 2021
@snitin315 snitin315 marked this pull request as ready for review Apr 9, 2021
lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
Copy link
Member

@aladdin-add aladdin-add left a comment

can you add some tests to confirm the issue to be fixed? thanks!

Loading

@snitin315
Copy link
Contributor Author

@snitin315 snitin315 commented Apr 17, 2021

I see there is no integration test for the whole workflow of --init. Should I add one?

Loading

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 17, 2021

👍 good to have!

Loading

lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
@snitin315 snitin315 force-pushed the fix/init branch 3 times, most recently from 5e288cc to e4bc626 Apr 20, 2021
@snitin315
Copy link
Contributor Author

@snitin315 snitin315 commented Apr 20, 2021

@aladdin-add @mdjermanovic I have added some test cases.

Loading

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks! 💯

Loading

@aladdin-add aladdin-add requested a review from mdjermanovic Apr 21, 2021
Copy link
Member

@btmills btmills left a comment

LGTM. Thanks for adding the non-.cjs tests as part of this!

Loading

lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
tests/lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
tests/lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
@snitin315
Copy link
Contributor Author

@snitin315 snitin315 commented Apr 24, 2021

@mdjermanovic Thanks for reviewing, I have applied your feedback. Please take a look again.

Loading

@nzakas
Copy link
Member

@nzakas nzakas commented May 4, 2021

@mdjermanovic can you take another look at this?

Loading

Copy link
Member

@mdjermanovic mdjermanovic left a comment

@snitin315 sorry for the delay! Looks great, I left some small suggestions about tests.

Loading

tests/lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
tests/lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
tests/lib/init/config-initializer.js Outdated Show resolved Hide resolved
Loading
tests/lib/init/config-initializer.js Show resolved Hide resolved
Loading
@snitin315
Copy link
Contributor Author

@snitin315 snitin315 commented May 5, 2021

@mdjermanovic All done 🚀

Loading

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Thanks @snitin315, LGTM!

Loading

nzakas
nzakas approved these changes May 6, 2021
Copy link
Member

@nzakas nzakas left a comment

Nice work!

Loading

@nzakas nzakas merged commit ee3a3ea into eslint:master May 6, 2021
14 checks passed
Loading
@snitin315 snitin315 deleted the fix/init branch May 6, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants