New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: remove meta.docs.category in core rules (fixes #13398) #14594
Conversation
We should figure out the release plan for this, taking into account the following facts:
If we don't need to see the rules page on the prelease website (
|
If we want to see the rules page on the prerelease site, we could update the prerelease process to create/overwrite First prerelease:
Release:
|
I think it's fine to wait until the final release before updating the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like we have a bunch of merge conflicts here. @aladdin-add can you take a look? |
chore: rm meta.cat from core rules chore: do not require meta.cat in internal rules chore: rename cat => ruletype Chore: rename conf/category-list.json => rule-type-list.json chore: update tools/update-rule-types chore: review suggestions Update conf/rule-type-list.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> Update Makefile.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@aladdin-add are you still working on this? |
sure. seems there was something wrong when fixing the conflicts. will look later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any concerns about merging this? Prereleases do not update |
No concerns here. |
Okay, I'm merging this so that we can publish a version where rules don't have |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fixes #13398
Is there anything you'd like reviewers to focus on?
eslint/website needs to be updated, too.