Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-implicit-coercion false positive with String() (fixes #14623) #14641

Merged
merged 1 commit into from Jun 4, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 30, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #14623 (the accepted part)

What changes did you make? (Give an overview)

Fixed the no-implicit-coercion rule to treat String(...) as a string value and thus not report string coercions on it.

Also added this check for the disallowTemplateShorthand option.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels May 30, 2021
@mdjermanovic mdjermanovic merged commit 1f048cb into master Jun 4, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the issue14623 branch Jun 4, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 2, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-implicit-coercion: <string expression> + "" triggers false positive
2 participants