Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix comment location in no-unused-vars #14648

Merged
merged 1 commit into from Jun 4, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented May 31, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fixes location of // in RHS of an assignment for itself... comment in no-unused-vars.js. While reviewing #14354, I noticed that the comment was misplaced, probably due to autofixing in 7ad86de, Also, the parentheses didn't make much sense.

What changes did you make? (Give an overview)

Fixed the comment location and rearranged parentheses.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels May 31, 2021
Copy link
Member

@btmills btmills left a comment

Nice readability improvement 👍

@mdjermanovic mdjermanovic merged commit d709abf into master Jun 4, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the nounusedvars-wrongcommentloc branch Jun 4, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 2, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants