Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade eslint-plugin-eslint-plugin #14738

Merged
merged 1 commit into from Jun 23, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 23, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ x] Other, please explain:

What changes did you make? (Give an overview)

update eslint-plugin-eslint-plugin to latest, it fixes a few false positives and false negatives.(a big thanks to @bmish !❤️ )

Is there anything you'd like reviewers to focus on?

no.

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Jun 23, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit f113cdd into eslint:master Jun 23, 2021
14 checks passed
@aladdin-add aladdin-add deleted the chore/upgrade-eslint-plugin branch Jul 15, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 21, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants