Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken links #14756

Merged
merged 2 commits into from Jun 29, 2021
Merged

Conversation

chenxsan
Copy link
Contributor

@chenxsan chenxsan commented Jun 29, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Update some links that could be broken once eslint/archive-website#856 is merged.

Is there anything you'd like reviewers to focus on?

There're some links with absolute path instead of relative one, e.g.,

[`--no-eslintrc`](https://eslint.org/docs/user-guide/command-line-interface#--no-eslintrc)

Shall we prefer relative path?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jun 29, 2021
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jun 29, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Jun 29, 2021

There're some links with absolute path instead of relative one, e.g.,

[`--no-eslintrc`](https://eslint.org/docs/user-guide/command-line-interface#--no-eslintrc)

Shall we prefer relative path?

It seems that some documents are using only absolute paths for some reason, so let's leave it as is for now.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks for contributing!

@mdjermanovic mdjermanovic merged commit aa87329 into eslint:master Jun 29, 2021
14 checks passed
@chenxsan chenxsan deleted the bugfix/fix-broken-links branch Jun 30, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 27, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants