Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: pin fs-teardown@0.1.1 #14771

Merged
merged 1 commit into from Jul 6, 2021
Merged

Chore: pin fs-teardown@0.1.1 #14771

merged 1 commit into from Jul 6, 2021

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Jul 5, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

This pins "fs-teardown": "0.1.1" to fix our CI on Node 10.12.0.

The latest 0.1.3 doesn't work on Node 10.12.0:

https://github.com/eslint/eslint/pull/14769/checks?check_run_id=2993896202

The previous 0.1.2 had a breaking change with trimming file contents. That wasn't noticed in this repo, but breaks some tests in eslint/eslintrc (eslint/eslintrc#44) so it feels safe to avoid the change.

What changes did you make? (Give an overview)

Set "fs-teardown": "0.1.1" in package.json.

Is there anything you'd like reviewers to focus on?

We can probably revert this change once we merge #14592

nzakas
nzakas approved these changes Jul 6, 2021
btmills
btmills approved these changes Jul 6, 2021
@aladdin-add aladdin-add merged commit a6a7438 into master Jul 6, 2021
14 checks passed
@aladdin-add aladdin-add deleted the fs-teardown-0.1.1 branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants