Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add non-capturing groups info to prefer-named-capture-group (fixes #15007) #15009

Merged
merged 1 commit into from Sep 4, 2021

Conversation

@akwodkiewicz
Copy link
Contributor

@akwodkiewicz akwodkiewicz commented Aug 31, 2021

Fixes #15007

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added information about the non-capturing groups to prefer-named-capture-group rule documentation.

Is there anything you'd like reviewers to focus on?

--

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Aug 31, 2021

CLA Signed

The committers are authorized under a signed CLA.

nzakas
nzakas approved these changes Sep 1, 2021
Copy link
Member

@nzakas nzakas left a comment

Nice addition. Thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

Thanks for contributing.

@nzakas nzakas merged commit 8c61f5a into eslint:master Sep 4, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants