Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add non-capturing groups info to prefer-named-capture-group (fixes #15007) #15009

Merged
merged 1 commit into from Sep 4, 2021

Conversation

akwodkiewicz
Copy link
Contributor

@akwodkiewicz akwodkiewicz commented Aug 31, 2021

Fixes #15007

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added information about the non-capturing groups to prefer-named-capture-group rule documentation.

Is there anything you'd like reviewers to focus on?

--

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 31, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2021

CLA Signed

The committers are authorized under a signed CLA.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 31, 2021
nzakas
nzakas approved these changes Sep 1, 2021
Copy link
Member

@nzakas nzakas left a comment

Nice addition. Thanks!

Copy link
Contributor

@snitin315 snitin315 left a comment

Thanks for contributing.

@nzakas nzakas merged commit 8c61f5a into eslint:master Sep 4, 2021
13 checks passed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 4, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add information about non-capturing regex groups in prefer-named-capture-group docs
4 participants