Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove instanceof from keyword-spacing docs #15180

Merged
merged 1 commit into from Oct 19, 2021

Conversation

mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 17, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Prr the keyword-spacing docs, this rule enforces spacing around instanceof, but that isn't true. This rule does not enforce spacing around infix operators, that's the responsibility of space-infix-ops.

What changes did you make? (Give an overview)

Removed instanceof from the keyword-spacing docs. Also clarified that in applies to for-in, not the in operator.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Oct 17, 2021
nzakas
nzakas approved these changes Oct 19, 2021
Copy link
Member

@nzakas nzakas left a comment

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants