Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove mention of mailing list #16853

Closed
wants to merge 1 commit into from
Closed

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Feb 3, 2023

Removes all mentions of the now-retired mailing list in our documentation.

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Because we've retired the mailing list, I've removed all mention of it.

Is there anything you'd like reviewers to focus on?

Removes all mentions of the now-retired mailing list in our
documentation.
@nzakas nzakas requested a review from a team as a code owner February 3, 2023 18:46
@eslint-github-bot eslint-github-bot bot added triage An ESLint team member will look at this issue soon documentation Relates to ESLint's documentation labels Feb 3, 2023
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b0f5ba3
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/63dd56a5f833da000872c448
😎 Deploy Preview https://deploy-preview-16853--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Feb 3, 2023
@@ -32,7 +32,7 @@ In your `.eslintrc` file, add:

### Where to ask for help?

Join our [Mailing List](https://groups.google.com/group/eslint) or [Chatroom](https://eslint.org/chat)
Open a [discussion](https://github.com/eslint/eslint/discussions) or stop by our [Discord server](https://eslint.org/chat) instead of filing an issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, there's another one here:

[Website](https://eslint.org) | [Configure ESLint](https://eslint.org/docs/latest/use/configure) | [Rules](https://eslint.org/docs/rules/) | [Contributing](https://eslint.org/docs/latest/contribute) | [Twitter](https://twitter.com/geteslint) | [Mailing List](https://groups.google.com/group/eslint) | [Chatroom](https://eslint.org/chat)

Copy link
Member

@amareshsm amareshsm Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdjermanovic
Copy link
Member

Can we also remove this one?

"group": "https://groups.google.com/group/eslint",

@@ -24,7 +24,7 @@ There are four primary issue categories:
1. **Bug** - something isn't working the way it's expected to work.
1. **Enhancement** - a change to something that already exists. For instance, adding a new option to an existing rule or a bug in a rule where fixing it will result in the rule reporting more problems (in this case, use both "Bug" and "Enhancement").
1. **Feature** - adding something that doesn't already exist. For example, adding a new rule, new formatter, or new command line flag.
1. **Question** - an inquiry about how something works that won't result in a code change. We'd prefer if people use the mailing list or chatroom for questions, but sometimes they'll open an issue.
1. **Question** - an inquiry about how something works that won't result in a code change. We'd prefer if people use discussions or chatroom for questions, but sometimes they'll open an issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention github discussions? or is it fine?

@nzakas
Copy link
Member Author

nzakas commented Feb 6, 2023

I was just doing this as a first pass. :) I'd love it if someone else could finish up this work so I can focus on RFCs. You can clone the branch I used for this PR and just modify it directly.

@nzakas nzakas closed this Feb 6, 2023
@nzakas nzakas deleted the no-more-mailing-list branch July 4, 2023 18:44
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 6, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants