New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove mention of mailing list #16853
Conversation
Removes all mentions of the now-retired mailing list in our documentation.
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -32,7 +32,7 @@ In your `.eslintrc` file, add: | |||
|
|||
### Where to ask for help? | |||
|
|||
Join our [Mailing List](https://groups.google.com/group/eslint) or [Chatroom](https://eslint.org/chat) | |||
Open a [discussion](https://github.com/eslint/eslint/discussions) or stop by our [Discord server](https://eslint.org/chat) instead of filing an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file, there's another one here:
[Website](https://eslint.org) | [Configure ESLint](https://eslint.org/docs/latest/use/configure) | [Rules](https://eslint.org/docs/rules/) | [Contributing](https://eslint.org/docs/latest/contribute) | [Twitter](https://twitter.com/geteslint) | [Mailing List](https://groups.google.com/group/eslint) | [Chatroom](https://eslint.org/chat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other occurrences:
eslint/docs/src/_data/links.json
Line 5 in 337f7ed
"group": "https://groups.google.com/group/eslint", |
eslint/docs/src/_data/sites/en.yml
Line 77 in 337f7ed
mailing_list: Google Group |
eslint/docs/src/_data/sites/zh-hans.yml
Line 76 in 337f7ed
mailing_list: Google Group |
Can we also remove this one? eslint/docs/src/_data/links.json Line 5 in 9b2fcf7
|
@@ -24,7 +24,7 @@ There are four primary issue categories: | |||
1. **Bug** - something isn't working the way it's expected to work. | |||
1. **Enhancement** - a change to something that already exists. For instance, adding a new option to an existing rule or a bug in a rule where fixing it will result in the rule reporting more problems (in this case, use both "Bug" and "Enhancement"). | |||
1. **Feature** - adding something that doesn't already exist. For example, adding a new rule, new formatter, or new command line flag. | |||
1. **Question** - an inquiry about how something works that won't result in a code change. We'd prefer if people use the mailing list or chatroom for questions, but sometimes they'll open an issue. | |||
1. **Question** - an inquiry about how something works that won't result in a code change. We'd prefer if people use discussions or chatroom for questions, but sometimes they'll open an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we mention github discussions? or is it fine?
I was just doing this as a first pass. :) I'd love it if someone else could finish up this work so I can focus on RFCs. You can clone the branch I used for this PR and just modify it directly. |
Removes all mentions of the now-retired mailing list in our documentation.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Because we've retired the mailing list, I've removed all mention of it.
Is there anything you'd like reviewers to focus on?