Replace context.sourceCode with context.getSourceCode() in no-war…

[CamillaTeodoro]

…ning-comments.js

For the rule no-warning-comments the variable sourceCode was undefined and resulting in the following error:

$ yarn lint           

yarn run v1.9.4
$ getk run lint-es '**/*.{js,jsx,ts,tsx}' --ignore-path .gitignore

Oops! Something went wrong! :(

ESLint: 8.43.0

TypeError: Cannot read properties of undefined (reading 'getAllComments')
Occurred while linting /Users/shermam/Projects/format-location/.eslintrc.js:1
Rule: "unicorn/expiring-todo-comments"
    at Object.Program (/Users/shermam/Projects/format-location/node_modules/eslint/lib/rules/no-warning-comments.js:193:45)
    at Program (/Users/shermam/Projects/format-location/node_modules/eslint-plugin-unicorn/rules/expiring-todo-comments.js:511:10)
    at /Users/shermam/Projects/format-location/node_modules/eslint-plugin-unicorn/rules/utils/rule.js:39:18
    at ruleErrorHandler (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1050:28)
    at /Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.enterNode (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
    at CodePathAnalyzer.enterNode (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:795:23)
    at /Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1085:32
    at Array.forEach (<anonymous>)
    at runRules (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1080:15)
    at Linter._verifyWithoutProcessors (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1330:31)
    at Linter._verifyWithoutProcessors (/Users/shermam/Projects/format-location/node_modules/eslint-plugin-eslint-comments/lib/utils/patch.js:166:36)
    at Linter._verifyWithConfigArray (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1706:21)
    at Linter.verify (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1412:65)
    at Linter.verifyAndFix (/Users/shermam/Projects/format-location/node_modules/eslint/lib/linter/linter.js:1967:29)
    at verifyText (/Users/shermam/Projects/format-location/node_modules/eslint/lib/cli-engine/cli-engine.js:245:48)
    at CLIEngine.executeOnFiles (/Users/shermam/Projects/format-location/node_modules/eslint/lib/cli-engine/cli-engine.js:825:28)
    at ESLint.lintFiles (/Users/shermam/Projects/format-location/node_modules/eslint/lib/eslint/eslint.js:551:23)
    at Object.execute (/Users/shermam/Projects/format-location/node_modules/eslint/lib/cli.js:391:36)
    at async main (/Users/shermam/Projects/format-location/node_modules/eslint/bin/eslint.js:135:24)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This change set updates the code to use context.getSourceCode() instead of context.sourceCode which is no longer defined.

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

[linux-foundation-easycla]

• ❌ - login: @CamillaTeodoro / name: Camilla Teodoro . The commit (c53c3a7) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[eslint-github-bot]

Hi @CamillaTeodoro!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase
• The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

[netlify]

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	c53c3a7
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/649ee045837cde0008958ca6

[mdjermanovic]

Hi @CamillaTeodoro!

Thanks for the PR but we can't accept this change because the current code is correct and this is actually a problem in eslint-plugin-unicorn's rule unicorn/expiring-todo-comments. Updating eslint-plugin-unicorn to the latest version should fix the error you're getting, as described in #17167.