New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: require-unicode-regexp
support v
flag
#17402
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
03c146c
feat: implement RegExp literal
sosukesuzuki 456055e
test: add tests for RegExp literal
sosukesuzuki cf2c231
feat: implement for RegExp constructor
sosukesuzuki 6019a22
test: add tests for RegExp constructor
sosukesuzuki 9970ae2
test: add invalid tests
sosukesuzuki 5a39eee
feat: implement replacement for u and v
sosukesuzuki b310c1a
test: add tests
sosukesuzuki 21ca659
docs: update docs for `v` flag
sosukesuzuki c510bad
fix: address review
sosukesuzuki 144f73d
Update lib/rules/require-unicode-regexp.js
sosukesuzuki 713c0c7
Update docs/src/rules/require-unicode-regexp.md
sosukesuzuki 082a792
Update tests/lib/rules/require-unicode-regexp.js
sosukesuzuki 93b828e
Update tests/lib/rules/require-unicode-regexp.js
sosukesuzuki File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links should go in a "Further Reading" section at the bottom of the page instead of here. See the semi rule as an example: https://eslint.org/docs/latest/rules/semi#further-reading